Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2150-es-wizard-crumb: Removes the if-clause to prepend Spanish… #2138

Merged
merged 7 commits into from
Dec 27, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Dec 20, 2024

… path by asking Drupal for the Breadcrumb URI in the expected language.

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2150

Description

Removes the need to check and prepend /es/ to Spanish wizard breadcrumbs

Type of Changes

  • New Feature
  • Bugfix - Refactor
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

Same verification steps as 2147

  1. Run bin/drush cr to ensure all caches are cleared
  2. Visit these links and check the breadcrumbs. All should have Página principal > Estafas y fraudes > Aprenda dónde reportar o denunciar una estafa (specifically, the last breadcrumb should not be a link to the Spanish home page, as it currently is in our dev and stage environments):
  • http://localhost/es/donde-reportar-una-estafa
    
  • http://localhost/es/donde-reportar-una-estafa/donde-ocurrio-estafa
    
  • http://localhost/es/donde-reportar-una-estafa/categoria-tipo-estafa
    
  1. Extra credit: check the result of running tome on this branch against dev.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

… path by asking Drupal for the Breadcrumb URI in the expected language.
@omerida omerida requested a review from akf December 20, 2024 16:51
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pages look good, Tome output is good.
The published-pages.csv has a problem: the /estafas-y-fraudes "taxonomy level 2" entry for wizard terms lacks the "/es". I see this code path being exercised for that breadcrumb, and that it actually doesn't generate a path with /es even though the language is provided.

@omerida omerida requested a review from akf December 26, 2024 20:16
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produces no change in HTML output nor in the PPR (as desired).

@akf akf merged commit c8dcc7a into dev Dec 27, 2024
4 of 5 checks passed
@akf akf deleted the USAGOV-2150-es-wizard-crumb branch December 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants