Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2116 PHPStan config #2130

Merged
merged 10 commits into from
Dec 27, 2024
Merged

USAGOV-2116 PHPStan config #2130

merged 10 commits into from
Dec 27, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Dec 19, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2116

Description

Installs phpstan for local scanning.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Run bin/composer install
  • Confirm shortcut bin/composer phpstan runs and shows errors.

Security Review

  • Adds/updates software (including a library or Drupal module)
    • Only adds new composer libraries as a developer dependency.
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do indeed see errors when I run this!
I'm just asking for a little tweak to the README.

README.md Outdated Show resolved Hide resolved
@omerida omerida requested a review from akf December 26, 2024 20:40
@akf
Copy link
Member

akf commented Dec 27, 2024

And now there's a merge conflict, alas.

@omerida
Copy link
Contributor Author

omerida commented Dec 27, 2024

@akf on it

README.md Outdated Show resolved Hide resolved
@omerida
Copy link
Contributor Author

omerida commented Dec 27, 2024

@akf merge conflict fixed

@akf akf merged commit 7ca7099 into dev Dec 27, 2024
6 checks passed
@akf akf deleted the USAGOV-2116-phsptan-config branch December 27, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants