-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USAGOV-2101: Add CODEOWNERS #2128
Conversation
… contacts for that module
… into USAGOV-2101-add-codeowners
…instead of email addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benefit finder has paragraphs:
- Benefit Eligibility (b_benefit_eligibility)
- Criteria (b_levent_elg_criteria)
- Criteria Group (b_levent_elg_criteria_group)
- Relevant Benefit (b_levent_relevant_benefit)
- Section (b_levent_elg_section)
The paragraphs and their fields begin with "b_"
% ls -1 | grep paragraph | grep b_
core.entity_form_display.paragraph.b_benefit_eligibility.default.yml
core.entity_form_display.paragraph.b_levent_elg_criteria.default.yml
core.entity_form_display.paragraph.b_levent_elg_criteria_group.default.yml
core.entity_form_display.paragraph.b_levent_elg_section.default.yml
core.entity_form_display.paragraph.b_levent_relevant_benefit.default.yml
core.entity_view_display.paragraph.b_benefit_eligibility.default.yml
core.entity_view_display.paragraph.b_levent_elg_criteria.default.yml
core.entity_view_display.paragraph.b_levent_elg_criteria_group.default.yml
core.entity_view_display.paragraph.b_levent_elg_section.default.yml
core.entity_view_display.paragraph.b_levent_relevant_benefit.default.yml
field.field.paragraph.b_benefit_eligibility.field_b_acceptable_values.yml
field.field.paragraph.b_benefit_eligibility.field_b_criteria_key.yml
field.field.paragraph.b_benefit_eligibility.field_b_label.yml
field.field.paragraph.b_levent_elg_criteria.field_b_children.yml
field.field.paragraph.b_levent_elg_criteria.field_b_criteria_key.yml
field.field.paragraph.b_levent_elg_criteria.field_b_error_message.yml
field.field.paragraph.b_levent_elg_criteria.field_b_hint.yml
field.field.paragraph.b_levent_elg_criteria.field_b_legend.yml
field.field.paragraph.b_levent_elg_criteria.field_b_required.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_criterias.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_description.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_heading.yml
field.field.paragraph.b_levent_elg_section.field_b_criterias.yml
field.field.paragraph.b_levent_elg_section.field_b_description.yml
field.field.paragraph.b_levent_elg_section.field_b_heading.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_body.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_cta.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_life_event_form.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_link.yml
field.storage.paragraph.field_b_acceptable_values.yml
field.storage.paragraph.field_b_body.yml
field.storage.paragraph.field_b_children.yml
field.storage.paragraph.field_b_criteria_key.yml
field.storage.paragraph.field_b_criterias.yml
field.storage.paragraph.field_b_cta.yml
field.storage.paragraph.field_b_description.yml
field.storage.paragraph.field_b_error_message.yml
field.storage.paragraph.field_b_heading.yml
field.storage.paragraph.field_b_hint.yml
field.storage.paragraph.field_b_label.yml
field.storage.paragraph.field_b_legend.yml
field.storage.paragraph.field_b_life_event_form.yml
field.storage.paragraph.field_b_link.yml
field.storage.paragraph.field_b_required.yml
paragraphs.paragraphs_type.b_benefit_eligibility.yml
paragraphs.paragraphs_type.b_levent_elg_criteria.yml
paragraphs.paragraphs_type.b_levent_elg_criteria_group.yml
paragraphs.paragraphs_type.b_levent_elg_section.yml
paragraphs.paragraphs_type.b_levent_relevant_benefit.yml
@gchi25 thanks! I added patterns for all those. |
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2101
Description
Add a CIODEOWNERS file. This initial version identifies users to be notified on PRs that touch benefits-finder code.
Type of Changes
Testing Instructions
Change Requirements
Validation Steps
I created a branch in which I modified the README.md in the usagov_benefit_finder module and made a PR against this branch (I have since closed the PR and deleted the branch). Scott and Gene should have received a notification from GitHub to review the PR.
The other thing to check is -- are the entries in this CODEOWNERS file correct for the purpose of giving Scott and Gene a heads-up when code for the benefit finder tool is updated?
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.