Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2101: Add CODEOWNERS #2128

Merged
merged 8 commits into from
Dec 27, 2024
Merged

USAGOV-2101: Add CODEOWNERS #2128

merged 8 commits into from
Dec 27, 2024

Conversation

akf
Copy link
Member

@akf akf commented Dec 18, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2101

Description

Add a CIODEOWNERS file. This initial version identifies users to be notified on PRs that touch benefits-finder code.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other - git configuration

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

I created a branch in which I modified the README.md in the usagov_benefit_finder module and made a PR against this branch (I have since closed the PR and deleted the branch). Scott and Gene should have received a notification from GitHub to review the PR.

The other thing to check is -- are the entries in this CODEOWNERS file correct for the purpose of giving Scott and Gene a heads-up when code for the benefit finder tool is updated?

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@akf akf marked this pull request as ready for review December 18, 2024 23:48
@akf akf marked this pull request as draft December 18, 2024 23:48
@akf akf marked this pull request as ready for review December 19, 2024 00:00
docs/CODEOWNERS Show resolved Hide resolved
@scottqueen-bixal
Copy link
Contributor

This seems about right to me @akf.

I'll have @gchi25 to review the config patterns and ensure we are covered there.

Copy link
Contributor

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benefit finder has paragraphs:

  • Benefit Eligibility (b_benefit_eligibility)
  • Criteria (b_levent_elg_criteria)
  • Criteria Group (b_levent_elg_criteria_group)
  • Relevant Benefit (b_levent_relevant_benefit)
  • Section (b_levent_elg_section)

The paragraphs and their fields begin with "b_"
% ls -1 | grep paragraph | grep b_
core.entity_form_display.paragraph.b_benefit_eligibility.default.yml
core.entity_form_display.paragraph.b_levent_elg_criteria.default.yml
core.entity_form_display.paragraph.b_levent_elg_criteria_group.default.yml
core.entity_form_display.paragraph.b_levent_elg_section.default.yml
core.entity_form_display.paragraph.b_levent_relevant_benefit.default.yml
core.entity_view_display.paragraph.b_benefit_eligibility.default.yml
core.entity_view_display.paragraph.b_levent_elg_criteria.default.yml
core.entity_view_display.paragraph.b_levent_elg_criteria_group.default.yml
core.entity_view_display.paragraph.b_levent_elg_section.default.yml
core.entity_view_display.paragraph.b_levent_relevant_benefit.default.yml
field.field.paragraph.b_benefit_eligibility.field_b_acceptable_values.yml
field.field.paragraph.b_benefit_eligibility.field_b_criteria_key.yml
field.field.paragraph.b_benefit_eligibility.field_b_label.yml
field.field.paragraph.b_levent_elg_criteria.field_b_children.yml
field.field.paragraph.b_levent_elg_criteria.field_b_criteria_key.yml
field.field.paragraph.b_levent_elg_criteria.field_b_error_message.yml
field.field.paragraph.b_levent_elg_criteria.field_b_hint.yml
field.field.paragraph.b_levent_elg_criteria.field_b_legend.yml
field.field.paragraph.b_levent_elg_criteria.field_b_required.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_criterias.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_description.yml
field.field.paragraph.b_levent_elg_criteria_group.field_b_heading.yml
field.field.paragraph.b_levent_elg_section.field_b_criterias.yml
field.field.paragraph.b_levent_elg_section.field_b_description.yml
field.field.paragraph.b_levent_elg_section.field_b_heading.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_body.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_cta.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_life_event_form.yml
field.field.paragraph.b_levent_relevant_benefit.field_b_link.yml
field.storage.paragraph.field_b_acceptable_values.yml
field.storage.paragraph.field_b_body.yml
field.storage.paragraph.field_b_children.yml
field.storage.paragraph.field_b_criteria_key.yml
field.storage.paragraph.field_b_criterias.yml
field.storage.paragraph.field_b_cta.yml
field.storage.paragraph.field_b_description.yml
field.storage.paragraph.field_b_error_message.yml
field.storage.paragraph.field_b_heading.yml
field.storage.paragraph.field_b_hint.yml
field.storage.paragraph.field_b_label.yml
field.storage.paragraph.field_b_legend.yml
field.storage.paragraph.field_b_life_event_form.yml
field.storage.paragraph.field_b_link.yml
field.storage.paragraph.field_b_required.yml
paragraphs.paragraphs_type.b_benefit_eligibility.yml
paragraphs.paragraphs_type.b_levent_elg_criteria.yml
paragraphs.paragraphs_type.b_levent_elg_criteria_group.yml
paragraphs.paragraphs_type.b_levent_elg_section.yml
paragraphs.paragraphs_type.b_levent_relevant_benefit.yml

@akf
Copy link
Member Author

akf commented Dec 20, 2024

@gchi25 thanks! I added patterns for all those.

docs/CODEOWNERS Show resolved Hide resolved
@akf akf merged commit a1e8a62 into dev Dec 27, 2024
3 of 5 checks passed
@akf akf deleted the USAGOV-2101-add-codeowners branch December 27, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants