-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usagov 2122 update custom code #2126
base: dev
Are you sure you want to change the base?
Conversation
…. update to circleCI config to use php83
… into USAGOV-2122-update-custom-code
…p83 compatibility, minor README cleanup
… into USAGOV-2122-update-custom-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! I flagged Gene on one benefits-finder file, so I'm not merging just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gchi25 Note that this PR will add an attribute to two functions here.
I expect that will be acceptable, but I'm going to hold off on approving this for a bit.
Heads up, there's a merge conflict now. |
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2122
Description
Added to ability to check for PHP8.3 issues
Type of Changes
Testing Instructions
run
bin/composer php-compatibility
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.