usagov-2077-usps-api-error: update code to remove specail characters …

[developer43]

…from the address

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2077

Description

Update logic to remove special characters in the address field before submitting to the USPS API

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • WWW
  • Egress
  • Tools
  • Cron
• Other

Testing Instructions

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Goto http://localhost/elected-officials and input the address below into the proper fields
  1 River Place, Apt #2908
  New York
  New York (NY)
  10036

• After submitting the address you should see the result without the special character in the address

• You SHOULD NOT see the xml error

• Repeat this verification on the Spanish page http://localhost/es/funcionarios-electos

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

This works, but there were some other special characters to test. In the Jira ticket I see:

Test other addresses using special characters like: &, <, >, ", '

It turns out the only one of those that's causing trouble is <.

You could simplify this a little. You don't need to check for # character before doing the replacement. So you could take that "if" statement out and after this:
streetAddress = streetAddress.replace('#', '');
add this:
streetAddress = streetAddress.replace('<', '');

[akf]

Please remove this commented-out code.