Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-150: USAGOV-150 - Increase height of the USWDS Components dialog #2116

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

DaleMHFrey
Copy link
Contributor

Bigger opening / window for the "Select USWDS Components to Embed"

https://cm-jira.usa.gov/browse/USAGOV-150

Description

Increased the height of the pop-up modal dialog-window for USWDS Components in the WYSIWYG

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Merge branch, flush cache. Then go to add a new Basic Page. Click the "USWDS Components" button in the WYSIWYG toolbar. You should now see the modal pop-up window is larger compared to Stage/Prod.

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@akf akf merged commit 76c2b93 into dev Dec 17, 2024
4 of 5 checks passed
@akf akf deleted the USAGOV-150 branch December 17, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants