Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2042 - Invoke CircleCI cron deployment to tools space from prod workflow, rather than dr workflow #2048

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

arpage
Copy link
Collaborator

@arpage arpage commented Oct 31, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2042

Description

Modify appropriate entity names to contain "prod" not "dr", change appropriate branches to "prod" not "dr".
Remove cron deployment to shared-egress space, for now.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

When deploying the cron app to the prod cf space via CircleCI, the "approve" step should spawn 2 "really-approve" steps - one for the prod space, and one for the tools space.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

…. Invoke tools space cron deployment from prod workflow, not dr workflow.
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akf akf merged commit a470f6b into dev Nov 7, 2024
5 of 6 checks passed
@akf akf deleted the USAGOV-2042-cci-dr-to-prod branch November 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants