Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usagov 1975 left nav current page is a link #2032

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

cwacht
Copy link
Contributor

@cwacht cwacht commented Oct 23, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1975

Description

This changes the leftnav's current item into a div instead of a link and adjusts the styles so that they apply to the div.

Testing Instructions

  • Visit any page with a left nav
  • Confirm that the current item is a div instead of a link
  • Confirm that the current page indicator is a visually hidden element
  • The HTML of the current item should match this structure:
<div class="active-trail usa-current">
  <p class="usa-sr-only">current page</p>
  Branches of government
</div> 

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@developer43 developer43 self-requested a review October 23, 2024 14:47
@developer43
Copy link
Contributor

Screenshots of verification
Screenshot 2024-10-23 at 10 50 59 AM

Screenshot 2024-10-23 at 10 51 10 AM

@cwacht cwacht marked this pull request as ready for review October 29, 2024 19:24
@omerida omerida merged commit abd98e1 into dev Nov 4, 2024
5 of 6 checks passed
@omerida omerida deleted the USAGOV-1975-left-nav-current-page-is-a-link branch November 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants