Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usagov-1953-incorrect-status-announced: update code to add a class at… #2021

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

developer43
Copy link
Contributor

… form submission

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1953

Description

I updated the reportAProblem javascript file to add a class to the form upon submission so the error doesn't appear if there are no errors

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Goto http://localhost/site-issue-report-form and http://localhost/es/reporte-problemas-en-este-sitio-web.

  1. On each page do not fill out the form to make sure the error box appears at the top of the form of the with the number of errors
  2. Fill out on error field and make sure the number of errors in the error box changes to "2"
  3. Fill out another field so now 2 fields will be filled out and make sure the number in the error box changes "1"
  4. Fill out all fields and submit the form and make sure the error box doesn't appear at the top of the form.

Screenshot of current form with error box after submission with no errors
Screenshot 2024-10-18 at 11 31 47 AM

Screenshot of updated form with no error box after submission no errors
Screenshot 2024-10-18 at 11 42 05 AM

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@omerida omerida merged commit 8dc378f into dev Oct 28, 2024
5 of 6 checks passed
@omerida omerida deleted the usagov-1953-incorrect-status-announced branch October 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants