Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1969 Manage search result weights #2013

Merged
merged 15 commits into from
Oct 24, 2024
Merged

USAGOV-1969 Manage search result weights #2013

merged 15 commits into from
Oct 24, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Oct 16, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1969

Description

Installs the sortableviews module to provide a drag-and-drop UI for managing the weight field of search results.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • On English benefit finder page, should see a local task linking to the sorting view.

image

  • Clicking on the link should take you to the view for sorting English benefit pages. /admin/manage-benefits-search-sort/en

image

- Change the order of some items (click on handle to activate , then click and drag to new location).
- Return to the benefit search page and confirm your new order is reflected in the search results. May need a cache refresh to get the latest json file for search order.
  • Spanish benefit finder page should have a similar local task that goes to /admin/manage-benefits-search-sort/en and affects the order of search results in the same way as above.
  • Confirm the local task does not show up on other pages.
  • Confirm the local task shows up if you're logged in as a Content Administrator or Site Admin
  • Confirm the local task does not show up for other roles.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

Provides two new views for content editors to manage benefit page search result weights in a draggable UI
… Spanish benefit weights.

Adds a local task on a benefits search page that links to the view for managing search results for a language.
Add a permission to manage who can edit search result weights.
@omerida omerida marked this pull request as ready for review October 16, 2024 19:59
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I'd recommend we wait until after tomorrow's push to staging to merge it, so the content team (okay, Shoshana) can give it a thorough look.

Also, I don't think we want verbose logging, unless I've missed something. (Even though the cms isn't meant to be for the public, it is exposed.)

config/sync/system.logging.yml Outdated Show resolved Hide resolved
@omerida
Copy link
Contributor Author

omerida commented Oct 17, 2024 via email

@omerida omerida requested a review from akf October 22, 2024 16:13
@akf akf merged commit 7ecc210 into dev Oct 24, 2024
5 of 6 checks passed
@akf akf deleted the USAGOV-1969-manage-weights branch October 24, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants