-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USAGOV-1969 Manage search result weights #2013
Conversation
Provides two new views for content editors to manage benefit page search result weights in a draggable UI
… Spanish benefit weights. Adds a local task on a benefits search page that links to the view for managing search results for a language. Add a permission to manage who can edit search result weights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but I'd recommend we wait until after tomorrow's push to staging to merge it, so the content team (okay, Shoshana) can give it a thorough look.
Also, I don't think we want verbose logging, unless I've missed something. (Even though the cms isn't meant to be for the public, it is exposed.)
yes, that was for testing, I kept unstaging it but I missed it in the end
…On Wed, Oct 16, 2024 at 10:00 PM A.K. Farrell ***@***.***> wrote:
***@***.**** requested changes on this pull request.
It looks good but I'd recommend we wait until after tomorrow's push to
staging to merge it, so the content team (okay, Shoshana) can give it a
thorough look.
Also, I don't think we want verbose logging, unless I've missed something.
(Even though the cms isn't meant to be for the public, it is exposed.)
------------------------------
On config/sync/system.logging.yml
<#2013 (comment)>:
Was this just for testing, by chance?
—
Reply to this email directly, view it on GitHub
<#2013 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYSHTXRAFSGKKLTTNLLJ3Z34K4LAVCNFSM6AAAAABQCGK6OOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZTHE3TMNZWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-1969
Description
Installs the sortableviews module to provide a drag-and-drop UI for managing the weight field of search results.
Type of Changes
Testing Instructions
Change Requirements
Validation Steps
/admin/manage-benefits-search-sort/en
/admin/manage-benefits-search-sort/en
and affects the order of search results in the same way as above.Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.