Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1613: USAGOV-1613 - CEO form has extra space on the left #1989

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

DaleMHFrey
Copy link
Contributor

https://cm-jira.usa.gov/browse/USAGOV-1613

Description

remove the "spacing"-classes from the texboxes that were adding the extra space on them.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

You can simply open a page to /elected-officials and confirm whether the left-edge of the textboxes are aligned vertically with the "All fields are required" text, and the "Results are provided" text.

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@developer43 developer43 self-requested a review October 4, 2024 17:02
@developer43
Copy link
Contributor

I verified this is correct

Screenshot 2024-10-04 at 1 04 24 PM

@developer43 developer43 merged commit ac39052 into dev Oct 4, 2024
5 of 6 checks passed
@developer43 developer43 deleted the USAGOV-1613 branch October 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants