Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXBF release v0.7.0.beta.1 #1988

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Oct 2, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-

Description

https://github.com/GSA/px-benefit-finder/releases/tag/v0.7.0.beta.1
https://github.com/GSA/px-benefit-finder/milestone/13?closed=1

Release v0.7.0.beta.1

Related Github Issue

https://github.com/GSA/px-benefit-finder/milestone/13

Application Improvements

beforeunload event not handling full data object GSA/px-benefit-finder#1816

Content Improvements

Stray HTML on "Explore other potential benefits" page GSA/px-benefit-finder#1814
Add display order field in life event GSA/px-benefit-finder#1795

a11y Improvements

a11y - Modal Zoom Scaling GSA/px-benefit-finder#1585

Custom Module Improvements

Add display order field in life event GSA/px-benefit-finder#1795
Make link field of relevant benefits of life event form required GSA/px-benefit-finder#1769
Provide warning message when deleting benefit in use GSA/px-benefit-finder#1479

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

Detailed Testing steps

Application Improvements

beforeunload event not handling full data object GSA/px-benefit-finder#1816

  • navigate to /death
  • enter data for first step of form
  • CLICK back button in browser
  • expect to see an alert
  • cancel
  • complete required fields in first step of form
  • navigate to second step
  • CLICK back button in browser
  • expect to see an alert
  • repeat for steps to test on results page

Content Improvements

Stray HTML on "Explore other potential benefits" page GSA/px-benefit-finder#1814

  • complete form with required fields and answer yes to others
  • on results view CLICK, "Explore other potential benefits"
  • ensure closing </p> tag is not rendered in string

reported:
Screenshot 2024-09-17 at 10 33 36 AM

expected:
Screenshot 2024-09-17 at 10 27 47 AM
Screenshot 2024-09-17 at 10 29 04 AM

a11y Improvements

a11y - Modal Zoom Scaling GSA/px-benefit-finder#1585

  • navigate to /benefit-finder/death -> modal view step
  • ensure modal overlay sits above usagov global elements

expected
Screenshot 2024-09-12 at 11 51 25 AM

  • zoom browser window to 400%
  • ensure close, title, and both nav buttons are in the view

expected
Screenshot 2024-09-12 at 11 51 08 AM

Custom Module Improvements

Add display order field in life event GSA/px-benefit-finder#1795

  • navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • go to life event "Benefit finder: death of a loved one" edit page
  • verify that it has Display Order field

Make link field of relevant benefits of life event form required GSA/px-benefit-finder#1769

  • navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • go to life event form "Benefit finder: death of a loved one" edit page
  • verify that link field of relevant benefit is required

Provide warning message when deleting benefit in use GSA/px-benefit-finder#1479

  • Navigate to admin/content?combine=&type=bears_benefit&status=All&langcode=All
  • Go to benefit "COVID-19 funeral assistance" edit form
  • CLICK "Delete" button
  • Verify the message of this benefit is used in following content

image

  • Go to benefit "COVID-19 funeral assistance" edit form again
  • CLICK "Delete" in the bottom
  • Verify the message of this benefit is used in following content in pop up window

image

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review October 2, 2024 20:45
Copy link
Contributor

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Worked as expected.

Copy link
Collaborator

@IsabelLaurenceau IsabelLaurenceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected

@IsabelLaurenceau IsabelLaurenceau merged commit f3b48d2 into dev Oct 7, 2024
6 of 7 checks passed
@IsabelLaurenceau IsabelLaurenceau deleted the pxbf-release-v0.7.0.beta.1 branch October 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants