Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-
Description
https://github.com/GSA/px-benefit-finder/releases/tag/v0.7.0.beta.1
https://github.com/GSA/px-benefit-finder/milestone/13?closed=1
Release v0.7.0.beta.1
Related Github Issue
https://github.com/GSA/px-benefit-finder/milestone/13
Application Improvements
beforeunload event not handling full data object GSA/px-benefit-finder#1816
Content Improvements
Stray HTML on "Explore other potential benefits" page GSA/px-benefit-finder#1814
Add display order field in life event GSA/px-benefit-finder#1795
a11y Improvements
a11y - Modal Zoom Scaling GSA/px-benefit-finder#1585
Custom Module Improvements
Add display order field in life event GSA/px-benefit-finder#1795
Make link field of relevant benefits of life event form required GSA/px-benefit-finder#1769
Provide warning message when deleting benefit in use GSA/px-benefit-finder#1479
Type of Changes
Testing Instructions
Change Requirements
Validation Steps
Detailed Testing steps
Application Improvements
beforeunload event not handling full data object GSA/px-benefit-finder#1816
Content Improvements
Stray HTML on "Explore other potential benefits" page GSA/px-benefit-finder#1814
</p>
tag is not rendered in stringreported:
expected:
a11y Improvements
a11y - Modal Zoom Scaling GSA/px-benefit-finder#1585
/benefit-finder/death
-> modal view stepexpected
expected
Custom Module Improvements
Add display order field in life event GSA/px-benefit-finder#1795
admin/content?combine=&type=bears_life_event&status=All&langcode=All
Make link field of relevant benefits of life event form required GSA/px-benefit-finder#1769
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Provide warning message when deleting benefit in use GSA/px-benefit-finder#1479
admin/content?combine=&type=bears_benefit&status=All&langcode=All
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.