Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1925: USAGOV-1925 - When the body is empty generating FAQs fails #1977

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

DaleMHFrey
Copy link
Contributor

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1925

Description

Introduced logic that confirms the body is not empty on a Node before trying to generate FAQs.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Simply go to the URI of /es/prestamos-del-gobierno which is an example page that has the FAQ checkbox ticked on the Edit-tab, but has an empty body. The page loads, but you will see errors and stack-traces printing out in your terminal/error-log.

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@YaritzaGarcia YaritzaGarcia self-requested a review October 2, 2024 18:09
@YaritzaGarcia YaritzaGarcia merged commit 968540a into dev Oct 2, 2024
5 of 6 checks passed
@YaritzaGarcia YaritzaGarcia deleted the USAGOV-1925 branch October 2, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants