USAGOV-1925: USAGOV-1925 - When the body is empty generating FAQs fails #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-1925
Description
Introduced logic that confirms the body is not empty on a Node before trying to generate FAQs.
Type of Changes
Testing Instructions
Simply go to the URI of
/es/prestamos-del-gobierno
which is an example page that has the FAQ checkbox ticked on the Edit-tab, but has an empty body. The page loads, but you will see errors and stack-traces printing out in your terminal/error-log.Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.