Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1479-Analytics-Reporter-Header #1971

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Conversation

IsabelLaurenceau
Copy link
Collaborator

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1479

Description

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Easiest way to test this is using "Go Live" extension in vscode.
  • From website-analytics/index.html use Go Live to open preview site.
  • No data will be loaded that is fine for this ticket.
  • The links "about this site" and "download data" should be on the same line as the dropdown
  • The analytics dashboard H1 header should be under the blue line

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@IsabelLaurenceau IsabelLaurenceau marked this pull request as ready for review September 23, 2024 18:58
@YaritzaGarcia YaritzaGarcia self-requested a review October 2, 2024 18:29
@YaritzaGarcia YaritzaGarcia merged commit 71d8142 into dev Oct 2, 2024
5 of 6 checks passed
@YaritzaGarcia YaritzaGarcia deleted the USAGOV-1479-AR-Header branch October 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants