-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USAGOV-1926: PXBF release v0.6.1.beta.1 #1920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Worked as expected.
I've flagged @IsabelLaurenceau to review this tomorrow morning, as I'm swamped. |
Good morning! Working on this review. For "Application improvements"- GSA/px-benefit-finder#1737 can you let me know how to "update proxy url to point at our main bxdev env" please? I've reviewed everything else and they all pass! |
@IsabelLaurenceau Looks like some of our local testing steps made it into this PR. You don't need to perform those, if all_benefits and death life events are published in a recent DB, you should be able to complete the Improvement manual tests. |
Hm @scottqueen-bixal the error isn't getting flagged when I put the valid input back to select. It looks like it's doing what your second video shows (8-30 at 10.15.21AM) but I was following the first instructions and expecting what the first video shows (8-30 at 10.08.22AM) Screen.Recording.2024-09-05.at.8.53.06.AM.mov |
indeed, that should be handled differently - tracking a bug ticket for a v0.6.2 patch here Error handling on required fields not persisting with default select options GSA/px-benefit-finder#1772 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with Scott. Will deploy this with a patch 0.6.2 coming later for the one missing error handling piece
Benefit Finder Release v0.6.1.beta.1
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-1926
Related Github Issue
https://github.com/GSA/px-benefit-finder/releases/tag/v0.6.1.beta.1
https://github.com/GSA/px-benefit-finder/milestone/11?closed=1
Data improvements
Update crazyegg variable programatically GSA/px-benefit-finder#1755
Design improvements
Include all benefits icon GSA/px-benefit-finder#1739
DESIGN | Update Typography across application GSA/px-benefit-finder#1445
Application improvements
Error message not working on date fieldsets with out required flag GSA/px-benefit-finder#1737
Content improvements
UX Content Changes GSA/px-benefit-finder#1662
Description
Type of Changes
Testing Instructions
Detailed Testing steps
Data improvements
Update crazyegg variable programatically GSA/px-benefit-finder#1755
Header
field/death
<head />
to ensure that it renderedAs you navigate through the app, we expect that the value assigned to CE_SNAPSHOT_NAME updates
this is how we will construct the name in the application
for example
So the values would look like this....
The current know life event ids are as follows,
Design improvements
Include all benefits icon GSA/px-benefit-finder#1739
all_benefits
andes_all_benefits
nodesadmin/content?combine=&type=bears_life_event_form&status=All&langcode=All
expected:
DESIGN | Update Typography across application GSA/px-benefit-finder#1445
/death
Expected view(s)
Application Improvements
Error message not working on date fieldsets with out required flag GSA/px-benefit-finder#1737
/death
<select />
input--Select--
from the now valid inputexpected:
Screen.Recording.2024-08-30.at.10.08.22.AM.mov
all_benefits
node/all_benefits
--Select--
from the now invalid input--Select--
from the now invalid inputexpected:
Screen.Recording.2024-08-30.at.10.15.21.AM.mov
Content improvements
UX Content Changes GSA/px-benefit-finder#1662
Detailed Testing steps
expected:
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.