Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1675: PXBF release v0.4.1.beta.1 #1667

Merged
merged 4 commits into from
Jun 28, 2024
Merged

USAGOV-1675: PXBF release v0.4.1.beta.1 #1667

merged 4 commits into from
Jun 28, 2024

Conversation

gchi25
Copy link
Contributor

@gchi25 gchi25 commented Jun 26, 2024

Benefit Finder v0.4.1.beta.1
https://github.com/gsa/px-benefit-finder/releases/tag/v0.4.1.beta.1

Related Issues

https://github.com/GSA/px-benefit-finder/milestone/8?closed=1

Description

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Infrastructure
    • CMS
    • WAF
    • Egress
    • Tools
  • Other

Requires New Config

  • Yes (regenerate all of JSON Data Files)
  • No

Requires New Content

  • Yes
  • No

Testing Instructions

Related Github Issue

Benefit Finder Module Improvements

Criteria hasChild cannot be unchecked if having children GSA/px-benefit-finder#870
Add search title field in life event GSA/px-benefit-finder#1427

Detailed Testing steps

Custom Module Improvements

Add search title in life event GSA/px-benefit-finder#1427

To test in local development site or in dev site.

  • pull changes locally
  • make local development site up at http://localhost
  • navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • go to life event "Benefit finder: death of a loved one" edit page
  • verify that it has search title field

Criteria uncheck has-child validation GSA/px-benefit-finder#870

Test in local development site or in dev.

  • Pull changes locally
  • Make local development site up at http://localhost
  • Navigate to /admin/content?combine=military&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Deceased served in active military" Edit page
  • Uncheck "Has Child" field
  • Click Save
  • Get error message of "Can not uncheck has-child field

image

  • Navigate to /admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page.
  • Remove all the 3 children of Deceased served in active military.

image

  • Go to criteria "Deceased served in active military" edit page again
  • Uncheck "Has Child"
  • Click "Save"
  • The criteria is saved and updated with "Has Child" unchecked

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@gchi25 gchi25 changed the title pxbf-release-v0.4.1.beta.1: criteria uncheck haschild validation USAGOV-1620: PXBF release v0.4.1.beta.1 Jun 26, 2024
@gchi25 gchi25 requested a review from scottqueen-bixal June 26, 2024 19:44
@gchi25 gchi25 self-assigned this Jun 26, 2024
@scottqueen-bixal scottqueen-bixal requested a review from omerida June 26, 2024 21:50
@scottqueen-bixal
Copy link
Contributor

@omerida can you have a review of the work related to the "Add search title in life event" in this PR?

@scottqueen-bixal
Copy link
Contributor

@gchi25 let's include testing instructions after Get error message of "Can not uncheck has-child field that examples removing the related entity child from the form, saving, then testing that you can remove the child relationship from the criteria.

@scottqueen-bixal
Copy link
Contributor

preliminary approved as working, can move forward once @omerida has confirmed his request update is accepted.

@gchi25 gchi25 requested a review from akf June 28, 2024 18:03
@akf akf changed the title USAGOV-1620: PXBF release v0.4.1.beta.1 USAGOV-1675: PXBF release v0.4.1.beta.1 Jun 28, 2024
@akf akf merged commit 6c8e0f0 into dev Jun 28, 2024
1 of 2 checks passed
@akf akf deleted the pxbf-release-v0.4.1.beta.1 branch June 28, 2024 20:05
@akf akf restored the pxbf-release-v0.4.1.beta.1 branch June 28, 2024 20:05
@akf akf mentioned this pull request Jun 28, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants