This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add accessibility scans #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be run with `yarn run pa11y-ci`
CI environment matches production closely, while giving us the ability to verify that we are not running in production. This will be important for scanning pages that in production are only available to logged-in users
|
Pa11y Failures detected Show failure message |
|
Pa11y Failures detected Show failure message |
|
Pa11y Failures detected Show failure message |
hartsick
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
I can't test out locally yet because I need the Rails master key, but looks good! A question and thought, neither blocking:
- Should we add the pa11y scan to our default rake task? (I'm inclined to, treat it as part of test suite we expect to pass)
- I've not used pa11y before on projects, only axe-core/matchers. I'd love to talk with you about how we expect this to work to make sure my understand is correct, and to talk about if there's a way to make sure that we're continuing to include new pages in a11y scans (I see there's a config—does it web crawl, or do we need to add each new URL in order to be scanned? Or should we think about pointing it at a site map down the road?)
I'm 50/50 on this. I like the default scan to be real quick, and pa11y is maybe a bit slower than I'd like. Maybe a task that does both the default and also runs pa11y that we can get in the habit of using? Or add it to the default and back it out to the full if/when it takes too long? Either way I'll create a new task to do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
pa11y-cifor running accessibility scans locally and in Github actions./bin/pa11y-scanciRails environment, that closely matches production. This helps pa11y and security scans not get tripped up by false positives that happen in development and test environmentsGithub Action will add a comment to the associated PR if it detects a problem