(graphcache) - Reimplement default-storage serializer/deserializer #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 0d11c8f We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/optimistic-persistence
branch
2 times, most recently
from
826aecf to
bf9fcd1
Compare
kitten
force-pushed
the
fix/optimistic-persistence
branch
from
bf9fcd1 to
0d11c8f
Compare
|
I can't wait to try it! |
|
Tried with codesandbox tar package. IT WORKS!!! :) |
|
Will you release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #864
Summary
This fixes an issue where deleted values wouldn't be persisted correctly, since the
default-storageserializer coerced bothnullandundefinedto"null"JSON values. The@urql/exchange/default-storageimplementation now comes with a new serializer which is incompatible with the old one but should be faster and more correct. It's incompatible with the old one, so the defaultidbNamehas been bumped tographcache-v4.Set of changes
data.persistsetdefault-storage