(graphcache) - should not store undefined values in storage #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 2abab2b We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I tried with codesandbox package. It works! Can you release it please? |
kitten
reviewed
Jun 14, 2020
| data += `${stringifyVariables(key)}:${ | ||
| value !== undefined ? stringifyVariables(value) : 'null' | ||
| },`; | ||
| if (batch[key] !== undefined) { |
There was a problem hiding this comment.
This isn’t quite right I believe, because we do need to ensure that this deletes / overrides old values.
So we may want to specially encode undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should not store undefined values since these aren't valid in GraphQL
Fixes: #864
Sandbox: https://codesandbox.io/s/urql-svelte-crud-with-indexeddb-cqg5i?file=/package.json
Set of changes