Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) - @urql/exchange-utils #796

Closed
wants to merge 2 commits into from
Closed

(feat) - @urql/exchange-utils #796

wants to merge 2 commits into from

Conversation

JoviDeCroock
Copy link
Collaborator

This kickstarts a package providing some common util-exchanges.

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2020

💥 No Changeset

Latest commit: 84c2084

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoviDeCroock JoviDeCroock changed the title start out on the development for @urql/exchange-utils (feat) - @urql/exchange-utils May 6, 2020
@JoviDeCroock JoviDeCroock requested review from kitten and wgolledge May 9, 2020 07:33
Copy link
Contributor

@wgolledge wgolledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I know it follows the current convention but the /exchange-utils confuses me slightly; it makes me think that the package may contain utils for other exchanges

@kitten
Copy link
Member

kitten commented May 10, 2020

@wgolledge That's true! the name is a little ambiguous for what we may add. Maybe @urql/exchange-tools would be nicer, i.e. exchanges/tools/?

@JoviDeCroock JoviDeCroock deleted the kickstart-utils branch June 18, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants