(suspense) - Fix suspenseExchange affecting subscriptions and add deprecation note #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscription Operations are never subject to suspense-mode.
🦋 Changeset is good to goLatest commit: 4ca6faa We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
May 3, 2020
|
Hi all, I confirm my problem disappeared with the sandbox build of suspense exchange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This doesn't affect server-side / SSR support! It's only for the
suspenseExchangeof the@urql/exchange-suspensepackageThis adds a fix that would affect
subscriptionoperations, although they remain untouched by suspense-mode.It also adds a deprecation note, since client-side suspense in
urqlisn't as stable as it should be and overall not very useful.This PR will remain opened for discussion briefly, if anyone has good arguments as to why this package shouldn't be deprecated.