Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache fix for null data #437

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Cache fix for null data #437

merged 2 commits into from
Sep 25, 2019

Conversation

andyrichardson
Copy link
Contributor

About

Fix issue where a null data response with an error will result in cached errors

@andyrichardson andyrichardson added the bug 🐛 Oh no! A bug or unintented behaviour. label Sep 25, 2019
JoviDeCroock
JoviDeCroock approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andyrichardson andyrichardson merged commit 555d0f2 into master Sep 25, 2019
@andyrichardson andyrichardson deleted the cache-fix branch September 25, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@kitten kitten kitten approved these changes

Assignees
No one assigned
Labels
bug 🐛 Oh no! A bug or unintented behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyrichardson @kitten @JoviDeCroock