fix(core): make metadata available in production

[alpavlove]

Fixes #3715

Summary

This change addresses a bug where the addMetadata function was being stripped or modified in production builds, resulting in the meta field being unavailable. The absence of meta caused inconsistent behaviour between development and production environments, particularly for TTL-based re-requests and cache outcomes.

Previously, there was an attempt to add back the meta to production bundles, but perhaps the babel file was missed.

Set of Changes

Modified Babel Transformer:

Updated the Babel transformer to preserve addMetadata calls in production, ensuring metadata (e.g., cacheOutcome) is always available.

Affected Package:

@urql/core: The core package was updated to fix the issue.

[changeset-bot]

🦋 Changeset detected

Latest commit: d1aa67a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@urql/core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[redroot]

@isy @JoviDeCroock any chance you guys could review this please?

[JoviDeCroock]

@redroot we remove the meta for a reason, it's meant to be for development - a better solution here might be to move it away from development metadata or for us to split up metadata in dev and not dev.

EDIT: I looked deeper into the few places where this transform is used and yeah, we should remove it entirely

[alpavlove]

It seems I can not merge myself due to a lack of permissions. Could you do it, @JoviDeCroock?

[JoviDeCroock]

@alpavlove That's normal yes, you are not a collab/member

[alpavlove]

@JoviDeCroock, unfortunately, it can't be released due to an error on CI
https://github.com/urql-graphql/urql/actions/runs/12234320213/job/34123275528

[alpavlove]

Thanks for getting this over the line, @JoviDeCroock!

[RomanFausek]

@alpavlove @JoviDeCroock are you sure this works? I am using the latest libs and still don't see the meta.

We use priceSummary.operation?.context?.meta?.cacheOutcome !== 'hit' in our code which works on localhost but devel/stage/prod doesn't see meta

[alpavlove]

@alpavlove @JoviDeCroock are you sure this works? I am using the latest libs and still don't see the meta.

Yes, it's working on my end. I'd recommend you ensure you're using at least version 5.1.0

[RomanFausek]

@alpavlove @JoviDeCroock are you sure this works? I am using the latest libs and still don't see the meta.

Yes, it's working on my end. I'd recommend you ensure you're using at least version 5.1.0

I am using the latest libraries. Coming from the lock file:

"@urql/core@>=4.0.0", "@urql/core@^5.0.0":
  version "5.1.0"
  resolved "https://registry.yarnpkg.com/@urql/core/-/core-5.1.0.tgz#7f4b81f1aba1ca34ae6354763abeb87ff9af84ff"
  dependencies:
    "@0no-co/graphql.web" "^1.0.5"
    wonka "^6.3.2"

And all the other libs are hooked with deps urql/core: ^5.0.0. So this is not the issue.

As I mentioned, it is working on localhost, is not working on the devel environment, and is not deployed to prod yet so I don't know. Any ideas? Do I need to configure something specific I missed?

[JoviDeCroock]

@RomanFausek Are you by any chance using GraphCache instead of the document cache?

[RomanFausek]

@RomanFausek Are you by any chance using GraphCache instead of the document cache?

Yes, I am using graphcache. Is that it?

[RomanFausek]

@JoviDeCroock Could you provide more details, please? I'm curious why it works in one case but not in the other. Is there any workaround to get it working? 🤔

[JoviDeCroock]

Because graphCache does not set that entry as the cache is far more nuanced with partial and stale reads

Edit: nvm we actually did end up implementing it but we didn't release a new version of gcache