Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(site): Fix no favicon on site (except on home page) #3678

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Neluji
Copy link
Contributor

@Neluji Neluji commented Sep 18, 2024

Summary

On any page of the docs site (i.e. https://commerce.nearform.com/open-source/urql/docs/basics/vue/), the favicon is missing, due to a 404 error trying to fetch it.

Set of changes

The path to the favicon is relatively defined in html.js, changing it to absolute path.

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: e1d4c58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kitten kitten changed the title Fix no favicon on site (except on home page) site: Fix no favicon on site (except on home page) Sep 19, 2024
@kitten kitten changed the title site: Fix no favicon on site (except on home page) docs(site): Fix no favicon on site (except on home page) Sep 19, 2024
@kitten kitten merged commit f26a346 into urql-graphql:main Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants