perf(vue): use shallowRef for data #3641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As graphql response usually contains a quite huge nested objects structure, wrapping it with
ref()
is not memory efficient.Instead of doing this, it's more efficient to use
shallowRef()
fordata
reactive variable, where the payload is stored.However, in #3611 while optimizing other variables, @negezor missed the
data
variable. I can assume there was a reason for that, so I consider this PR as a suggestion/discussion. Personally, I don't see any negative side effects from usingshallowRef()
, but maybe you guys have some thought on it.I see only one possible scenario in which this would be a "breaking change": updating some nested
data
parts manually outside of this plugin, but I'd say - this is a quite specific pattern.Set of changes
ref()
withshallowRef()
for thedata
variable