fix(bindings): Fix handlers for subscriptions receiving null #3581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
Reported on Discord
The subscription handlers infer their new value argument type as
T
ofOperationResult<T>
. This means thatdata: null
cases are uncovered and the handler may accidentally receivenull
values when the types specify that this isn't possible.This may happen when a trailing value of a subscription contains a fatal error rather than a result value.
In this case it should be safe to ignore the value, since the subscription will either be restarted by the subscription client (or a
retryExchange
), or will terminate.Set of changes
null
values before passingresult.data
to subscription handlers