Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix @ts-ignore directive on TS import in type declaration output #3567

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Apr 18, 2024

@kitten kitten requested a review from JoviDeCroock April 18, 2024 11:39
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 513a31e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit 1805b92 into main Apr 18, 2024
13 checks passed
@kitten kitten deleted the fix/ts-ignore-output branch April 18, 2024 11:52
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
@IvanUkhov
Copy link

I think you forgot to update the dependency on 0no-co/graphql.web. It still depends on the version with that problem.

@kitten
Copy link
Member Author

kitten commented Apr 18, 2024

@IvanUkhov It's within range:

"@0no-co/graphql.web": "^1.0.5",

Typically, I wouldn't bump that unless there's an explicit reliance on changes in the sub-package (like API changes). Since it's in range and the fix isn't preventing anyone from using it (i.e. if it's discovered, I'd hope the first thing someone does is to upgrade the broken dependency transitively). especially since skipLibCheck in TS is common I'd just leave it be

@IvanUkhov
Copy link

Good point. People will figure out to update if case they bump into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants