Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphcache): Improve Graphcache resolver consistency #3336

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 26, 2023

Summary

While looking at a code snippet, I found that we didn't come back to providing parent[info.fieldName] for scalar resolvers. This is an easy way of making this work. It does add a bit of overhead, but I think it's the only way to add this without a breaking change (and without doing a weird set/delete dance, which is likely to be slower)

The other issue is that info.parentFieldKey isn't consistently populated with the fieldKey (as is implied and documented) but with info.parentKey joined with the fieldKey, i.e. a full key.

This means that cache.resolve(parent, info.parentFieldKey) wouldn't work in resolvers, but would work in updaters.

Set of changes

  • Replace incorrect updateContext calls to fix info.parentFieldKey in resolvers
  • Update parent input for scalar fields to have both parent[fieldAlias] and parent[fieldName] set to the record value

@kitten kitten merged commit 3afa802 into main Jul 26, 2023
@kitten kitten deleted the fix/graphcache-resolver-inconsistencies branch July 26, 2023 19:49
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant