fix(react): Fix execute functions' state change being discarded after pause change #3323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3289
Supersedes #3289
Summary
This updates the outdated dependencies array in
react-urql
’suseQuery
(which still containedgetSnapshot
) and addsargs.pause
. It does the same inuseSubscription
.When
executeQuery
/executeSubscription
are not re-created when all dependencies change, the first render when they're outdated would refresh the dependencies to an older version, causing the source to be immediately overridden again.This specifically caused an edge case because the dependencies didn't include
args.pause
. This means that the execute functions are outdated the render afterargs.pause
changes, and means that their state change is immediately overwritten.Set of changes
executeQuery
/executeSubscription
dependencies to account forargs.pause
changes