Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean up Client result source logic and allow multiple mutation results #3102

Merged
merged 8 commits into from
Mar 27, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 27, 2023

Summary

This cleans up the Client’s createExecutionRequest and makeResultSource logic. Specifically, it groups a couple of code branches, and refactors the reused source to use a simple lazy source rather than a make source.

Furthermore, it will allow multiple mutation results to be issued. A follow-up PR for bindings is needed here.

Set of changes

  • Clean up Client logic
  • Replace make result source with lazy
  • Add takeWhile(result => !!result.hasNext, true) instead of take(1) on mutations

@kitten kitten requested a review from JoviDeCroock March 27, 2023 15:34
@kitten kitten merged commit 849025f into main Mar 27, 2023
@kitten kitten deleted the refactor/client-cleanup branch March 27, 2023 15:50
This was referenced Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants