fix(core): Add missing dedupe operation logic #3101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the missing logic that handles deduplication before a response has come back for a query or subscription operation. While we already ported logic from the
dedupExchange
to theClient
that disallowed sending new operations for operations that currently have ahasNext
flag set or are active, we now also take care of dispatched operations that haven't received a response yet.The tests validate that the behaviour is equivalent to before and that operations are dispatched when
reexecuteOperation
is called, since those are on a delay, so that reexecutions can come through, forrequestPolicy
upgrades (e.g. forcache-and-network
)Set of changes
teardown
anddispatched
checks toClient
fordedupExchange
replacement logic