feat(core): Add support for graphql.js’ built-in TypedQueryDocumentNode #3085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
graphql.js
now has a built-in type for typedDocumentNode
s, which we must adopt to support tools that rely on this type instead of@graphql-typed-document-node/core
.We can maintain our prior approach of having a copied type to maintain backwards- and forwards- compatibility by extending our own type with the type property carrying the types we need. The only difference to the other package is that
graphql.js
uses a different name for the property: https://github.com/graphql/graphql-js/blob/e171a14/src/utilities/typedQueryDocumentNode.ts#L8-L22This has been tested with the following ts file:
Set of changes
__ensureTypesOfVariablesAndResultMatching
property toTypedDocumentNode