Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Refactor hasNext/stale on OperationResult to be required #3061

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 16, 2023

Summary

Since OperationResult.hasNext is now important to determine whether operations should be deduplicated (as before, to be fair), and OperationResult.stale is important for toPromise to find the right result, it's a little dangerous not to have them be required.

Hence, the thinking here is to make them required and to ensure that for @defer/@stream we won't run into cases where those never reset to false or where deferred/streamed responses are duplicated.

Set of changes

  • Update hasNext and stale to be required
  • Update tests and types

@kitten kitten requested a review from JoviDeCroock March 16, 2023 02:22
@kitten kitten added the major 🚚 Changes queued for a new major release, which will include breaking changes label Mar 16, 2023
@kitten kitten merged commit 2fc9842 into main Mar 16, 2023
@kitten kitten deleted the refactor/hasnext-stale-required branch March 16, 2023 14:12
This was referenced Mar 16, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major 🚚 Changes queued for a new major release, which will include breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants