Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate the dedupExchange and absorb hasNext checks into Client #3058

Merged
merged 10 commits into from
Mar 16, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 15, 2023

Summary

This deprecates the dedupExchange and turns it into a noop exchange.

The logic that dedupExchange applied was already effectively taken care of by the Client and we only needed small modifications to prevent dispatching when hasNext: true is present on any given subscription or query result, i.e. when we're still waiting for updates.

Set of changes

  • Add hasNext dispatch stop to Client
  • Replace dedupExchange with noop logic

@kitten kitten requested a review from JoviDeCroock March 15, 2023 22:21
@kitten kitten force-pushed the feat/deprecate-dedup branch 3 times, most recently from 6d9b5ef to b74715f Compare March 16, 2023 00:14
@kitten kitten force-pushed the feat/deprecate-dedup branch from b74715f to 9b4dec1 Compare March 16, 2023 00:27
@kitten
Copy link
Member Author

kitten commented Mar 16, 2023

This may vibe well with #3033. I have no idea if we'll get major resistance if we were to drop a major with that, but if we are to get rid of the dedupExchange, then there's really not much left for most apps.

We'd start avoiding [...defaultExchanges, x] mistakes automatically and by default, there's only two exchanges to add really. So, I think we may want to drop both at the same time.

@kitten kitten added the major 🚚 Changes queued for a new major release, which will include breaking changes label Mar 16, 2023
@kitten kitten merged commit 7222ee1 into main Mar 16, 2023
@kitten kitten deleted the feat/deprecate-dedup branch March 16, 2023 14:10
This was referenced Mar 16, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major 🚚 Changes queued for a new major release, which will include breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants