fix(auth): Fix willAuthError not being called on waiting operations #3017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When operations are waiting for
authPromise
to resolve, i.e. they're not queued but instead are waiting for the authentication update/refresh to resolve,willAuthError
will actually not be called, even if it's provided.This can lead to an easy mistake, where the authentication state may have been rehydrated (on startup), but is never checked to be valid.
We now queue operations that are waiting for the promise like we do for failed operations, which simplifies the logic a little, and make sure to call
willAuthError
on them again.Set of changes
willAuthError
on queued retry operationsmutate
bypasses the authentication logic