Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphcache): Fix blocking of legitimate reexecutions after teardowns #2876

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

kitten
Copy link
Member

@kitten kitten commented Dec 10, 2022

Resolve #2835

Summary

This fixes Graphcache blocking legitimate reexecutions triggerd by the UI. These reexecutions could be triggered due to the previously introduced looping protection #2737.

When an operation is torn down and reactivated without any other network request inbetween, then Graphcache wouldn't clean up the operations that'd be blocked from refetching. This meant that it'd erroneously block a legitimate operation triggered by the UI.

The protection is meant to only trigger requests that'd potentially infinitely trigger requests, i.e. non-network-only operations triggered by cache misses.

This has been addressed by adding a missing clean up call in reaction to teardowns.

Set of changes

  • Add missing reexecutingOperations clean up to teardown handler
  • Remove typings/build testing line that we added to test a Rollup+TS build issue

@kitten kitten requested a review from JoviDeCroock December 10, 2022 00:00
@kitten kitten merged commit cad2575 into main Dec 10, 2022
@kitten kitten deleted the fix/blocked-reexecution branch December 10, 2022 09:24
@github-actions github-actions bot mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Urql doesn't make a http request to the server on component remount and gets stuck on fetching.
2 participants