fix(graphcache): Fix blocking of legitimate reexecutions after teardowns #2876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2835
Summary
This fixes Graphcache blocking legitimate reexecutions triggerd by the UI. These reexecutions could be triggered due to the previously introduced looping protection #2737.
When an operation is torn down and reactivated without any other network request inbetween, then Graphcache wouldn't clean up the operations that'd be blocked from refetching. This meant that it'd erroneously block a legitimate operation triggered by the UI.
The protection is meant to only trigger requests that'd potentially infinitely trigger requests, i.e. non-
network-only
operations triggered by cache misses.This has been addressed by adding a missing clean up call in reaction to teardowns.
Set of changes
reexecutingOperations
clean up toteardown
handler