fix(core): Fix regression causing stringifyDocument to not reprint after formatDocument #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
force-pushed
the
create-reproduction-missing-typename
branch
from
189d811 to
6673abf
Compare
JoviDeCroock
force-pushed
the
create-reproduction-missing-typename
branch
from
1651fa4 to
0234037
Compare
kitten
reviewed
Dec 9, 2022
kitten
changed the title
kitten
approved these changes
Dec 9, 2022
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2869 reproduces the issue.
this looks to be the problem, when we use
createRequestwe fill ingqlas the source name and don't update the printed string when looping over it withformatDocument. When we usegqlthe name will begraphql requesthence not hitting this clause.The thing concerning me here is if people would be implementing local-only exchanges whether that would mess with i.e. them removing a field when seeing
@local