feat(graphcache): Remove refLock and add dirtyKeys / skip GC runs in unsettled states #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
force-pushed
the
feat/skip-gc-runs
branch
2 times, most recently
from
91f2595 to
6e7c493
Compare
JoviDeCroock
approved these changes
Dec 7, 2022
…unsettled state This skips GC runs when we previously would've used `refLock` to skip over entities that are "locked" by optimistic and deferred layers. Instead, we now simply skip GC runs when `optimisticOrder` is non-empty, meaning that we simply forgo garbage collection runs when we know it's unlikely we'll need them.
kitten
force-pushed
the
feat/skip-gc-runs
branch
from
6e7c493 to
e359593
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This skips GC runs when we previously would've used
refLockto skip over entities that are "locked" by optimistic and deferred layers. Instead, we now simply skip GC runs whenoptimisticOrderis non-empty, meaning that we simply forgo garbage collection runs when we know it's unlikely we'll need them.The motivation of this change is to reduce the complexity of
InMemoryDatacode further, and to remove the added work and event loop pressure by scheduling garbage collection runs when we could simply wait a bit longer to schedule it.Set of changes
refLockfrom datadirtyKeysinstead, to track layers we've createdwriteLinkcode