-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workspace): Migrate from yarn to pnpm #2837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebd976a
to
21d871c
Compare
21d871c
to
e89fd1e
Compare
d841f32
to
ddd7791
Compare
ddd7791
to
189ba7d
Compare
c6f0a16
to
914a66d
Compare
10f1172
to
8005f4b
Compare
2e5f766
to
7547cf1
Compare
JoviDeCroock
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We basically want to achieve a couple things by switching over
pnpm
.We get the basic benefits of speed and a nicer setup from
pnpm
over the aging (old) Yarn.Its dependencies structure and it enforcing those by default forces us to clean up old discrepancies and implicit, transitive dependencies we collected over time.
This was mainly difficult however to realise because our specific use of
tsconfig.json
paths for resolving our local packages needed adjustments and specifically needed more changes to Rollup and Vite-based builds. However, this is expected, and we simply "got away" with not having proper resolutions for these before because of the specific symlinking nature of Yarn.Set of changes
pnpm-workspace.yaml
pnpm import
tsconfig.json
paths to relative pathsreact-static-plugin-md-pages
(updated to not use a virtual module)@graphql-typed-document-node/core
into@urql/core