Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): Migrate from yarn to pnpm #2837

Merged
merged 16 commits into from
Nov 28, 2022
Merged

chore(workspace): Migrate from yarn to pnpm #2837

merged 16 commits into from
Nov 28, 2022

Conversation

kitten
Copy link
Member

@kitten kitten commented Nov 27, 2022

Summary

We basically want to achieve a couple things by switching over pnpm.
We get the basic benefits of speed and a nicer setup from pnpm over the aging (old) Yarn.

Its dependencies structure and it enforcing those by default forces us to clean up old discrepancies and implicit, transitive dependencies we collected over time.

This was mainly difficult however to realise because our specific use of tsconfig.json paths for resolving our local packages needed adjustments and specifically needed more changes to Rollup and Vite-based builds. However, this is expected, and we simply "got away" with not having proper resolutions for these before because of the specific symlinking nature of Yarn.

Set of changes

  • Add pnpm-workspace.yaml
  • Run pnpm import
  • Replace resolutions with overrides
  • Fix peer dependencies and mismatches
  • Update GitHub Actions
  • Add missing sub-dependencies to packages
  • Update tsconfig.json paths to relative paths
  • Update Vite and Vitest to use custom tsconfig-based resolvers plugin
  • Update Rollup to use tsconfig-based resolvers plugin
  • Update react-static-plugin-md-pages (updated to not use a virtual module)
  • Internalise @graphql-typed-document-node/core into @urql/core

@kitten kitten force-pushed the chore/yarn-to-pnpm branch 2 times, most recently from ebd976a to 21d871c Compare November 27, 2022 14:31
@github-actions github-actions bot temporarily deployed to staging-2837 November 27, 2022 14:32 Inactive
@kitten kitten force-pushed the chore/yarn-to-pnpm branch from 21d871c to e89fd1e Compare November 27, 2022 14:34
@github-actions github-actions bot temporarily deployed to staging-2837 November 27, 2022 14:36 Inactive
@github-actions github-actions bot temporarily deployed to staging-2837 November 27, 2022 14:37 Inactive
@kitten kitten force-pushed the chore/yarn-to-pnpm branch 8 times, most recently from d841f32 to ddd7791 Compare November 27, 2022 15:43
@kitten kitten force-pushed the chore/yarn-to-pnpm branch from ddd7791 to 189ba7d Compare November 27, 2022 15:47
@kitten kitten force-pushed the chore/yarn-to-pnpm branch from c6f0a16 to 914a66d Compare November 27, 2022 16:05
@kitten kitten force-pushed the chore/yarn-to-pnpm branch from 10f1172 to 8005f4b Compare November 27, 2022 16:11
@kitten kitten force-pushed the chore/yarn-to-pnpm branch from 2e5f766 to 7547cf1 Compare November 27, 2022 16:17
@github-actions github-actions bot temporarily deployed to staging-2837 November 28, 2022 05:07 Inactive
@kitten kitten marked this pull request as ready for review November 28, 2022 05:20
@kitten kitten requested a review from JoviDeCroock November 28, 2022 05:44
@kitten kitten merged commit 72e0ca2 into main Nov 28, 2022
@kitten kitten deleted the chore/yarn-to-pnpm branch November 28, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants