Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphcache): Fix typo in results cache #2741

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix(graphcache): Fix typo in results cache #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twelve-beds-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@urql/exchange-graphcache': patch
---

Fix referential equality preservation in Graphcache failing after API results, due to a typo writing the API result rather than the updated cache result.
2 changes: 1 addition & 1 deletion exchanges/graphcache/src/cacheExchange.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export const cacheExchange = <C extends Partial<CacheExchangeOpts>>(
// Collect the query's dependencies for future pending operation updates
queryDependencies = queryResult.dependencies;
collectPendingOperations(pendingOperations, queryDependencies);
results.set(operation.key, result.data);
results.set(operation.key, data);
}
} else {
noopDataState(store.data, operation.key);
Expand Down