fix(graphcache): consistent __typename removal #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7eca9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
force-pushed
the
ensure-typename-consistency
branch
from
b947f5e to
68fbc42
Compare
JoviDeCroock
changed the title
JoviDeCroock
commented
Oct 9, 2022
JoviDeCroock
commented
Oct 9, 2022
|
Superseded by da121d4 |
|
Testing a different approach this in #2736, which instead tries to preserve the original document and continue to prevent adding |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While investigating #2701 I noticed that we invalidate the result for a cache-hit due to not having
__typenamethere, on a closer look this is because when wefowardwe add the__typenameinformatDocument, this is also returned to the user because we have changed the operation itself, but when we get a result from cache we use the supplied query which might be missing these__typenameadditions.To counter-act this we will always query the result with the original query in mind
Set of changes