Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for fetchOptions updates #264

Closed
wants to merge 1 commit into from

Conversation

andyrichardson
Copy link
Contributor

Fix #234

@kitten
Copy link
Member

kitten commented Aug 5, 2019

@andyrichardson Do you think this is safe to merge now that @JoviDeCroock has written a comprehensive auth example/guide in #361?

@andyrichardson
Copy link
Contributor Author

@kitten no objections here, I'll un-draft the PR and get CI triggered

@andyrichardson andyrichardson marked this pull request as ready for review August 12, 2019 09:17
@JoviDeCroock
Copy link
Collaborator

@andyrichardson updating the snapshots should suffice for the CI

@kitten
Copy link
Member

kitten commented Aug 12, 2019

Hiya, I think I actually confused this PR 💕😅 Do we still need this PR given the auth exchange example in the guide?

@kitten
Copy link
Member

kitten commented Aug 16, 2019

Closing due to inactivity

@kitten kitten closed this Aug 16, 2019
@andyrichardson andyrichardson deleted the 234-add-config-updates branch November 20, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow to return promise in fetchOptions function
3 participants