major(graphcache): remove warning and lookup fields by name rather than alias #2616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2578
Resolves #2272
Summary
This PR does two things, removing us warning for
undefined
fields in optimistic mutations. Now we truely only error/warn for missing typenames and missing keys. Now we'll also leverage thefieldName
rather than thefieldAlias
to both invoke theoptimistic
mutation and look up the data from the return value.This resulted in one failing test which was removed as part of the PR
Set of changes
optimistic
part