Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Refactor utilities to reduce size (*.min.mjs) by -50B gzip'd #2611

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

kitten
Copy link
Member

@kitten kitten commented Aug 15, 2022

  • Simplify dedupExchange logic
  • Prevent onPush in fetch for production environments
  • Replace several for-loops with for-of loops
  • Use Set in collectTypes
  • Remove .some from formatNode

I'm explicitly not adding a changeset, since it doesn't actually affect the output code and to not pollute the eventual changelog with irrelevant entries.

@kitten kitten requested a review from JoviDeCroock August 15, 2022 23:39
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 59101a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kitten kitten changed the title chore(core): Refactor some utilities to reduce size of @urql/core (*.min.mjs) to 6.1kB gzip'd chore(core): Refactor some utilities to reduce size of @urql/core (*.min.mjs) by -50B gzip'd Aug 15, 2022
@kitten kitten changed the title chore(core): Refactor some utilities to reduce size of @urql/core (*.min.mjs) by -50B gzip'd chore(core): Refactor utilities to reduce size (*.min.mjs) by -50B gzip'd Aug 15, 2022
@kitten kitten merged commit ce00440 into main Aug 16, 2022
@kitten kitten deleted the chore/shed-bytes branch August 16, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants