(react) - Update initial state to not require abort on mount #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `useSyncExternalStore` reimplementation regressed on us constructing the correct initial state on mount, and instead relied on an abort on mount, which is confusing to users. Instead, we can simply revert to what we've done prior to the change and ensure that the initial state is accurate.
🦋 Changeset detectedLatest commit: 5667bff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
commented
Jan 31, 2022
| suspense: boolean; | ||
| }>({ | ||
| source: null, | ||
| }>(() => ({ |
There was a problem hiding this comment.
This isn't strictly speaking necessary, but let's avoid calling client.executeQuery on every render 😆
JoviDeCroock
approved these changes
Jan 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2226
Summary
Previously, the
useSyncExternalStorereimplementation regressedon us constructing the correct initial state on mount, and instead
relied on an abort on mount, which is confusing to users.
Instead, we can simply revert to what we've done prior to the
change and ensure that the initial state is accurate.
This fix does not change any of the current behaviour, but simply avoids the confusing state transition on mount.
Set of changes
useQueryimplementation