Make "async fetchOptionsExchange" example copy-able #1835
Conversation
|
docs/common-questions.md
Outdated
| ); | ||
| }; | ||
| export const fetchOptionsExchange = | ||
| (fn: (fetchOptions: RequestInit) => Promise<RequestInit>): Exchange => |
There was a problem hiding this comment.
to avoid issues we initially made this (fetchOptions: RequestInit) => Promise<RequestInit> | RequestInit and had a ternary that did this in the stream:
const result = fn(operation.context.fetchOptions);
return pipe(
typeof result.then === 'function' ? fromPromise(result) : fromValue(result),
);
This mainly to avoid introducing a footgun 😅 WDYT?
There was a problem hiding this comment.
Yep, sounds good. Fixed! Thanks for the tip 👍
Summary
The current example perfectly suits some use-cases but can't be used "as is". If you copy it into TS project, you'll see a few errors. Fixing these errors requires some understanding of exchange internals and wonka API.
I see two possibilities how to make it easier to get started with the
urqlhere:fetchOptionsExhangeto the core (as @RodolfoSilva originally suggested here)I implemented first as a simple solution, but maybe second would be even a better option?
Set of changes
Changed the current example a bit by adding the missing imports and types.