(core) - Fix ssrExchange.restoreData adding invalidated results #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 867f423 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jul 6, 2021
kitten
force-pushed
the
fix/repeated-restore-ssr
branch
from
88638de to
867f423
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1775
Resolve #1771
Summary
Prevent
ssrExchange().restoreData()from adding results to the exchange that have already been invalidated. This may happen whenrestoreData()is called repeatedly, e.g. per page. When a prior run has already invalidated an SSR result then the result is 'migrated' to the user'scacheExchange, which means thatrestoreData()should never attempt to re-add it again.Set of changes
ssrExchangewithnullrather thandeletenullentries to prevent overwriting invalidated results