Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(vue) - Simplify useQuery implementation #1758

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 1, 2021

Resolve #1429

Refactor useQuery implementation to utilise the single-source implementation of @urql/[email protected]. This should improve the stability of promisified useQuery() calls and prevent operations from not being issued in some edge cases.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

🦋 Changeset detected

Latest commit: 113f842

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more removed lines than added, count me in!

@kitten kitten marked this pull request as ready for review July 6, 2021 14:18
@kitten kitten merged commit a0fcea4 into main Jul 6, 2021
@kitten kitten deleted the fix/vue-suspense-deadlock branch July 6, 2021 14:22
@urql-ci urql-ci mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(vue) - Promisified useQuery deadlocks or fails to update fetching
2 participants