(next) - allow subsequent statically generated pages to hydrate the ssr-cache #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 07c1858 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
May 3, 2021
examples/with-next/pages/static-2.js
Outdated
| @@ -0,0 +1,54 @@ | |||
| import { initUrqlClient } from "next-urql"; | |||
There was a problem hiding this comment.
Can remove this page, mainly meant to illustrate/give a testing point for reviewers 😅
There was a problem hiding this comment.
Yea probably worth removing once you're done 😅
kitten
approved these changes
May 3, 2021
| @@ -55,6 +55,8 @@ export function withUrqlClient( | |||
| if (!ssr || typeof window === 'undefined') { | |||
| // We want to force the cache to hydrate, we do this by setting the isClient flag to true | |||
| ssr = ssrExchange({ initialState: urqlServerState, isClient: true }); | |||
| } else if (ssr && typeof window !== 'undefined') { | |||
| ssr.restoreData(urqlServerState); | |||
There was a problem hiding this comment.
That's really a pleasant surprise!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1567
Summary
Next will inject data available for a route as JSON, similar to how it does so for the first-page-serve, this is why we have to add a special else branch to account for this scenario.
Set of changes