(chore) - remove closure-compiler #1570
Conversation
…ained and we were seeing frequent issues with metro and bundles compiled by closure
🦋 Changeset detectedLatest commit: d97cfa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
changed the title
| @@ -0,0 +1,22 @@ | |||
| --- | |||
There was a problem hiding this comment.
This is just personal taste FWIW but I believe we shouldn't forcefully bump all builds, maybe? It'd be cool if there was a way to tell changesets to "ignore" one and only include it when a non-ignored change set was in a release too
Buble/Babel (and transformers in general) like to transform arrow functions to function expressions on variable declarations. At the toplevel of modules we can clean this up by replacing them with function declarations, which leads to cleaner minifier output.
|
Removing Closure Compiler (and Babel Plugin Closure Elimination) in this PR. Added a transformation to clean up arrow functions. Instead of having a lot of function expressions, a lot of those are now converted to function declarations which leads to a net negative bundle size on average |
Fixes: #1552
Summary
The current rollup plugin isn't really maintained and we were seeing frequent issues with metro and bundles compiled by closure
Set of changes
rollup-plugin-closure-compiler